Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default and Plain Styles from Quote Block #68457

Open
wants to merge 31 commits into
base: trunk
Choose a base branch
from
+3 −9
Open

Remove Default and Plain Styles from Quote Block #68457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
63f81c1
Image size fix in lightbox
karthick-murugan Dec 3, 2024
0e19583
Revert "Image size fix in lightbox"
karthick-murugan Dec 3, 2024
f226ae0
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 4, 2024
d074ba9
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 5, 2024
4d847ca
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 5, 2024
c9115b2
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 5, 2024
b81e6ff
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 6, 2024
efe57e5
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 9, 2024
228e924
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 10, 2024
c448a21
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 11, 2024
05bb54c
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 12, 2024
619fed3
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 12, 2024
301d70f
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 18, 2024
c80640f
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 19, 2024
6ed9ff3
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 20, 2024
09b4cf2
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 20, 2024
27e4bbc
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 20, 2024
52f809e
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 23, 2024
e7679f1
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Dec 24, 2024
190b44e
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 2, 2025
af5f6a1
Remove styles block in quote
karthick-murugan Jan 2, 2025
26aafe7
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 6, 2025
fe1916c
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 8, 2025
db39968
End2End test fixes
karthick-murugan Jan 9, 2025
5264e9c
e2e test fixes
karthick-murugan Jan 9, 2025
56abbce
e2e test fixes
karthick-murugan Jan 9, 2025
58dddf5
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 9, 2025
ff6f5e1
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 20, 2025
c239ca4
Merge branch 'WordPress:trunk' into trunk
karthick-murugan Jan 21, 2025
663cb85
Feedback changes
karthick-murugan Jan 24, 2025
09e1907
Merge branch 'trunk' of github.com:karthick-murugan/gutenberg into up…
karthick-murugan Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/block-library/src/quote/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,6 @@
"clientNavigation": true
}
},
"styles": [
{
"name": "default",
"label": "Default",
"isDefault": true
},
{ "name": "plain", "label": "Plain" }
],
"editorStyle": "wp-block-quote-editor",
"style": "wp-block-quote"
}
2 changes: 1 addition & 1 deletion packages/block-library/src/quote/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
border: none;
padding-left: 0;
}
// .is-style-large and .is-large are kept for backwards compatibility.
// .is-style-plain, .is-style-large and .is-large are kept for backwards compatibility.
// They are not wrapped in `:where()` to keep specificity as it was before
// they were deprecated.
&:where(.is-style-plain),
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/specs/editor/various/patterns.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,8 +605,10 @@
page
.getByRole( 'region', { name: 'Editor settings' } )
.getByRole( 'button', { name: 'Styles', exact: true } )
).toBeVisible();

Check failure on line 608 in test/e2e/specs/editor/various/patterns.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 4

[chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 

  1) [chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })


      606 | 				.getByRole( 'region', { name: 'Editor settings' } )
      607 | 				.getByRole( 'button', { name: 'Styles', exact: true } )
    > 608 | 		).toBeVisible();
          | 		  ^
      609 |
      610 | 		await page.click( 'role=menuitem[name="Plain Style"i]' ); // Update the selector based on UI changes.
      611 |
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/patterns.spec.js:608:5

Check failure on line 608 in test/e2e/specs/editor/various/patterns.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 4

[chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 

  1) [chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })


      606 | 				.getByRole( 'region', { name: 'Editor settings' } )
      607 | 				.getByRole( 'button', { name: 'Styles', exact: true } )
    > 608 | 		).toBeVisible();
          | 		  ^
      609 |
      610 | 		await page.click( 'role=menuitem[name="Plain Style"i]' ); // Update the selector based on UI changes.
      611 |
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/patterns.spec.js:608:5

Check failure on line 608 in test/e2e/specs/editor/various/patterns.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 4

[chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 

  1) [chromium] › editor/various/patterns.spec.js:590:2 › Synced pattern › should allow a block with styles to be converted to a reusable block 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })
    Expected: visible
    Received: <element(s) not found>
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByRole('region', { name: 'Editor settings' }).getByRole('button', { name: 'Styles', exact: true })


      606 | 				.getByRole( 'region', { name: 'Editor settings' } )
      607 | 				.getByRole( 'button', { name: 'Styles', exact: true } )
    > 608 | 		).toBeVisible();
          | 		  ^
      609 |
      610 | 		await page.click( 'role=menuitem[name="Plain Style"i]' ); // Update the selector based on UI changes.
      611 |
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/patterns.spec.js:608:5

await page.click( 'role=menuitem[name="Plain Style"i]' ); // Update the selector based on UI changes.

await editor.clickBlockOptionsMenuItem( 'Create pattern' );

const createPatternDialog = editor.page.getByRole( 'dialog', {
Expand Down
Loading