Polish menus and focus styles #6812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, |
|
I think I also fixed the Block More Menu btw. |
|
Rebased, and fixed an issue as a result of the buttons refactor. I think this is ready to go. |
ellatrix
reviewed
May 22, 2018
utils/keycodes.js
Outdated
| [ COMMAND ]: '⌘', | ||
| [ SHIFT ]: isMac ? '⇧shift' : 'Shift', | ||
| [ SHIFT ]: isMac ? 'Shift' : 'Shift', |
There was a problem hiding this comment.
This could be simplified to [ SHIFT ]: 'Shift',.
ellatrix
reviewed
May 22, 2018
utils/keycodes.js
Outdated
| [ ALT ]: isMac ? '⌥option' : 'Alt', | ||
| [ CTRL ]: isMac ? '⌃control' : 'Ctrl', | ||
| [ ALT ]: isMac ? 'Option' : 'Alt', | ||
| [ CTRL ]: isMac ? 'Ctrl' : 'Ctrl', |
There was a problem hiding this comment.
This could be simplified to [ CTRL ]: 'Ctrl',.
ellatrix
approved these changes
May 22, 2018
This fixes a regression in menu focus styles that was introduced as part of some focus fixes to the movers way back. It also fixes #6734, as it changes how the shortcuts are spelled out.
|
Addressed feedback, rebased, and merging if the checks pass. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in menu focus styles that was introduced as part of some focus fixes to the movers way back.
It also fixes #6734, as it changes how the shortcuts are spelled out.