Inserter: Hide child blocks from the inserter when needed #67734
+28
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Dec 9, 2024
|
Size Change: -96 B (-0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
juanfra
reviewed
Dec 9, 2024
|
Thanks, Riad! This almost works, but some bugs remain for the primary root (
Screenshot, group block example
|
|
It looks like the diff --git packages/block-editor/src/store/selectors.js packages/block-editor/src/store/selectors.js
index 8e2ce92eede..7ee0efd5f41 100644
--- packages/block-editor/src/store/selectors.js
+++ packages/block-editor/src/store/selectors.js
@@ -2061,6 +2061,7 @@ const buildBlockTypeItem =
return {
...blockItemBase,
initialAttributes: {},
+ ancestor: blockType.ancestor,
description: blockType.description,
category: blockType.category,
keywords: blockType.keywords, |
|
I think the "template parts" and "post content" blocks showing there are issues unrelated with the current PR. I'm not entirely sure how to solve this yet. |
Mamaduka
approved these changes
Dec 10, 2024
|
I created an issue here #67797 |
6 tasks
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…67734) Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: juanfra <juanfra@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65687
What?
In a previous iteration, we allowed all blocks to be visible in the inserter at any time. This has proven a bit confusing for blocks that require a parent block. These blocks should only be visible within their parent blocks. This PR solves that.
Testing Instructions
1- The "column" block shouldn't be visible when you're at the root level in the inserter
2- The "column" block should be visible when you're within a columns block.