Fix unexpected unlock control in block toolbar in non-default editing mode #67121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ef2be51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12120348972
|
t-hamano
reviewed
Nov 22, 2024
There was a problem hiding this comment.
This change looks correct to me (see this comment).
I would be happy if @youknowriad , @fabiankaegy , and @ajlende could double-check it.
|
Yes, I'm not entirely sure whether that was intentional. I guess the question is whether there's a case where the lock toolbar make sense for "zoom-out" or "content-only" blocks. |
I don't know about zoom-out. But I don't see any instance where a content only locked piece should be allowed to get unlocked 🤔 |
|
I agree. I can't see any use case for unlocking in these modes. That's a highly advanced feature and we should be explosing that in:
|
7877837 to
ef2be51
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@cbravobernal I've marked this as needing backport to 6.7 point release. Feel free to adjust as you see fit. |
|
I think this PR also solves the issue with blocks with <!-- wp:group {"layout":{"type":"constrained"}, "templateLock": "contentOnly"} -->
<div class="wp-block-group">
<!-- wp:paragraph -->
<p>Hello World</p>
<!-- /wp:paragraph -->
</div>
<!-- /wp:group -->WordPress 6.7.1❌ A lock icon will be displayed on the Paragraph block in the Group block where
This PR✅ The lock icon will not be displayed.
|
|
@t-hamano I believe so yes. This is targeting WP 6.7 point release where I believe the bug manifests itself by allowing you to unlock parts of the template which it shouldn't. Thanks for your review. |
|
@Mamaduka as far as I can tell the target is 6.7 because the bug is unique to 6.7. It does not exist in trunk and was caused by the removal of the zoomed out mode features from 6.7 |
|
Thanks @Mamaduka. I believe @youknowriad noted it doesn't manifest on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides the Lock controls in the Block toolbar when not in default editing mode.
Closes #67082
Why?
Unlocking is a advanced level action and is not required for
contentOnlyor when blocks aredisabled.It makes little sense in Zoom Out either.
How?
Adjust conditional to include
isDefaultEditingMode.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After