Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: React 19 <link /> for components #66781

Draft
wants to merge 22 commits into
base: try/react-19-beta
Choose a base branch
from
Draft

Try: React 19 <link /> for components #66781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4e3b86c
Bump react deps to 19.0.0-beta-6946ebe620-20240508
tyxla May 9, 2024
31c620b
Workaround portal iframe body handling limitations
tyxla Apr 3, 2024
356cb6e
Fix deprecated types: React.ReactChild
tyxla May 9, 2024
4ccf3b3
Fix deprecated types: React.ReactNodeArray
tyxla May 9, 2024
4ab64e3
Fix deprecated types: React.ReactFragment
tyxla May 9, 2024
2effce7
Fix deprecated types: React.ReactText
tyxla May 9, 2024
9f9e599
beta -> rc
tyxla May 23, 2024
e0dacce
Update a snapshot test
tyxla May 23, 2024
a8d3cfa
Fix context consumer serialization
tyxla May 23, 2024
230a404
Add @ariakit/react-core patch for element.props.ref support
tyxla May 23, 2024
f9df116
Fix some unit tests
tyxla May 23, 2024
ae7b177
REVERTME: Hack a test
tyxla May 23, 2024
840449f
Bump to 19.0.0-rc-100dfd7dab-20240701
tyxla Jul 2, 2024
63ac11d
Bump to 19.0.0-rc-33c7bd9a-20241104
tyxla Nov 6, 2024
c557a6e
Revert "Add @ariakit/react-core patch for element.props.ref support"
tyxla Nov 6, 2024
2d1ac29
Revert "React: Restore umd builds (#63602)"
tyxla Nov 6, 2024
39d6d4c
Edit Post: Check for meta box container before adding constraints
tyxla Nov 6, 2024
3e8a81a
Inserter: Fix InserterListbox rendering
tyxla Nov 6, 2024
6a9ada3
Bump framer-motion to 12.0.0-alpha.1
tyxla Nov 6, 2024
c04f169
ButtonGroup: Convert SCSS to CSS for testing
tyxla Nov 6, 2024
b7b8f14
Remove ButtonGroup styles from the components style monolith
tyxla Nov 6, 2024
f28bcea
ButtonGroup: Use <link /> for the stylesheet
tyxla Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 57 additions & 65 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@
"progress": "2.0.3",
"puppeteer-core": "23.1.0",
"raw-loader": "4.0.2",
"react": "18.3.1",
"react": "19.0.0-rc-33c7bd9a-20241104",
"react-docgen-typescript": "2.2.2",
"react-dom": "18.3.1",
"react-dom": "19.0.0-rc-33c7bd9a-20241104",
"react-native": "0.73.3",
"react-native-url-polyfill": "1.1.2",
"react-refresh": "0.14.0",
"react-scanner": "1.2.0",
"react-test-renderer": "18.3.1",
"react-test-renderer": "19.0.0-rc-33c7bd9a-20241104",
"reassure": "0.7.1",
"redux": "4.1.2",
"resize-observer-polyfill": "1.5.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-preset-default/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@wordpress/warning": "*",
"browserslist": "^4.21.10",
"core-js": "^3.31.0",
"react": "^18.3.0"
"react": "^19.0.0-rc-100dfd7dab-20240701"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/colors/test/with-colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe( 'createCustomColorsHOC', () => {
colors: undefined,
setBackgroundColor: expect.any( Function ),
} ),
expect.anything()
undefined
);
} );

Expand Down
7 changes: 2 additions & 5 deletions packages/block-editor/src/components/iframe/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,6 @@ function Iframe( {
${ styles }
${ scripts }
</head>
<body>
<script>document.currentScript.parentElement.remove()</script>
</body>
</html>`;

const [ src, cleanup ] = useMemo( () => {
Expand Down Expand Up @@ -468,7 +465,7 @@ function Iframe( {
}
} }
>
{ iframeDocument &&
{ iframeDocument?.body &&
createPortal(
// We want to prevent React events from bubbling throught the iframe
// we bubble these manually.
Expand All @@ -486,7 +483,7 @@ function Iframe( {
{ children }
</StyleProvider>
</body>,
iframeDocument.documentElement
iframeDocument?.documentElement
) }
</iframe>
{ shouldRenderFocusCaptureElements && after }
Expand Down
11 changes: 10 additions & 1 deletion packages/block-editor/src/components/inserter-listbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* WordPress dependencies
*/
import { Composite } from '@wordpress/components';
import { Fragment } from '@wordpress/element';

/**
* Internal dependencies
Expand All @@ -11,9 +12,17 @@ export { default as InserterListboxGroup } from './group';
export { default as InserterListboxRow } from './row';
export { default as InserterListboxItem } from './item';

function InserterListBoxWrapper( { key, children } ) {
return <Fragment key={ key }>{ children }</Fragment>;
}

function InserterListbox( { children } ) {
return (
<Composite focusShift focusWrap="horizontal" render={ <></> }>
<Composite
focusShift
focusWrap="horizontal"
render={ InserterListBoxWrapper }
>
{ children }
</Composite>
);
Expand Down
Loading
Loading