Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split view with meta boxes even with legacy canvas #66706

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Split view with meta boxes even with legacy canvas #66706

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e97c95
Split view with meta boxes with non-iframed canvas
stokesman Sep 11, 2024
dfe6935
Fix scrolling of device previews
stokesman Nov 2, 2024
be563d0
Consolidate styles and add comments
stokesman Nov 4, 2024
d008922
Do the same thing without adding a prop to BlockCanvas
stokesman Nov 19, 2024
2fdda78
Fix horizontal overflow of device previews
stokesman Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/use-resize-canvas/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default function useResizeCanvas( deviceType ) {
marginLeft: marginHorizontal,
marginRight: marginHorizontal,
height,
overflowY: 'auto',
Copy link
Contributor Author

@stokesman stokesman Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dates back to #19082 which introduced device previewing and it seems at the time the canvas was not iframed. Now device previews are always iframed and its document is the scrolling context so this rule has no purpose.

maxWidth: '100%',
};
default:
return {
Expand Down
Loading