Post editor: Fix "typewriter" spacing style application #65885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -57 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Oct 5, 2024
| }; | ||
| }, [] ); | ||
|
|
||
| const addedStyles = additionalStyles.join( '\n' ); |
There was a problem hiding this comment.
Nit: Currently there is only one style for the padding appender, so no line break will occur, but is the line break itself even necessary?
There was a problem hiding this comment.
No, it’s not necessary. Passing something as a separator is required to avoid the default comma. I suppose I opted for the line break as a formatting nicety despite the fact that it’d be a rare case that anyone is actually looking at the concatenated styles (and that as of yet there’s not more than one style so it’s moot for now). Here’s an example of what it looks like inspecting the element if there were more than one style.
empty string separator:
\n seperator:
I don’t mind making it an empty string or space if you’d opine it should be.
There was a problem hiding this comment.
I don't have any strong opinions about it, so I think it's fine to merge it as is 👍
|
I’ve changed the type label to "Bug" because I realized that in trunk the spacing is being applied in a couple contexts it’s not intended to. See the updated description for details and a screen recording. The bug could be fixed more minimally (it’s due to the lack of two dependencies in the memo hook within |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where the "typewriter" space below the post content is showing up when not intended:
Also this makes
usePaddingAppendercontain its concerns and support disabling it. Follows up on #64992.Why?
To fix a bug and improve code quality.
Currently, the hook is always active in the Post editor but doesn’t have an effect in some contexts (e.g. template editing, or focused editing of template parts or patterns). It returns early in those contexts by actively testing whether its associated styling is applied in the document. Such testing is potentially brittle and unnecessary because the same conditions that omit the styling can be used to inactivate the hook.
Besides that its associated styling and the conditions for applying it are in a separate hook that ideally doesn’t own those concerns.
How?
usePaddingAppenderis enableduseEditorStyleshook and uses them to control whether theusePaddingAppenderis enabledusePaddingAppenderown and return its stylesuseEditorStylesaccept additional styles so it can generically handle the style fromusePaddingAppenderTesting Instructions
Screen recording
This shows how on trunk the space gets added below the template when the template is set to show.
typewriter-space-after-template.mp4