Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages workspaces remove file refs #65708

Closed

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Sep 27, 2024

What?

Some ideas for #65681.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@sirreal sirreal force-pushed the packages-workspaces-remove-file-refs branch from cd35a7b to 460a2ba Compare September 27, 2024 15:42
@gziolo
Copy link
Member

gziolo commented Oct 10, 2024

The code that Lerna uses to replace local dependency links:

https://github.com/lerna/lerna/blob/28c8ef232d29085ce9a9ba2bff96fae9017b3963/libs/commands/publish/src/index.ts#L743-L765

Similar code for workspaces:

https://github.com/lerna/lerna/blob/28c8ef232d29085ce9a9ba2bff96fae9017b3963/libs/commands/publish/src/index.ts#L767-L802

I don't know how it exactly works, but it seems like using * might work fine with Lerna publishing, and it would get correctly replaced with the version number prefixed with ^.

@sirreal
Copy link
Member Author

sirreal commented Oct 16, 2024

This work has been merged into #65681

@sirreal sirreal closed this Oct 16, 2024
@sirreal sirreal deleted the packages-workspaces-remove-file-refs branch October 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants