Rename refs to fix tons of 'Mutating a value' errors in react-compiler #64718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 22, 2024
|
Flaky tests detected in 282b986. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10509434142
|
|
Thanks @Mamaduka 🙌
Indeed. Linting is also helpful here though - if there's a missed instance to update inline, we'd immediately see errors. I'll do one more manual self-review before merging. |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR renames all refs we mutate to follow the ref naming pattern recommended in facebook/react#29916.
Why?
As part of #61788 we're working to experiment with
react-compilerand early resolve any errors that can be blockers for using it.Renaming the refs to follow the naming pattern recommended in facebook/react#29916 takes care of 53 of the 140 lint errors.
I'm landing that as a separate improvement from #61788 to keep it minimal, but also because ref rename is pretty harmless on its own.
How?
We're renaming refs to follow the
somethingRefpattern:const something = useRef()becomesconst somethingRef = useRef()const exampleRef = useRef()remains unchangedTesting Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None