Make Query Loop settings more intuitive with a ToggleGroup and simplified help text

[kmanijak]

What?

Fixes #63598.
Swap "Inherit query from template" toggle with Contents: Default | Custom toggle group.

What	Before	After
inherit: true
inherit: false

Why?

This control has confused users (and engineers) for a long time now. This is an attempt to make it clearer as per #63598.

How?

Replace ToggleControl with ToggleGroupControl component.

Testing Instructions

1. Go to Editor and All Archives template
2. Focus on Query Loop block
3. Expected: There's "Contents" control as per screenshots above
4. Switch to "Custom"
5. Expected: All the customization controls appear
6. Switch back to "Default"
7. Expected: All the customization controls disappear and help text appears

Testing Instructions for Keyboard

Screenshots or screencast

[t-hamano]

Thanks for the PR!

I've provided some feedback on the code side, but overall it's working as expected.

As for the copy, let's continue to discuss what would be ideal.

[richtabor]

We should also make the post type help text much simpler:

"Select the type of content to display: posts, pages, or custom post types."

[kmanijak]

Thanks @t-hamano and @richtabor! I fixed a small code improvement suggestion but haven't changed anything regarding the copy yet.

Let's continue the discussion in #63598 and keep it as a single source of truth. Once everyone agrees there I'll apply the final version here and set the PR to review 🙌

[jameskoster]

Seems there's some consensus around this suggestion: #63598 (comment)

[kmanijak]

Seems there's some consensus around this suggestion: #63598 (comment)

@jameskoster , I don't feel like everyone agreed with this one yet 🤔

[jameskoster]

It feels like the best suggestion so far. Maybe it's worth updating the PR to give it a try? Sometimes it helps to interact with the control in-situ.

It's easy to change if it doesn't feel right :)

[kmanijak]

@jameskoster, yeah, makes sense 😅 pushed the changes, and here's how it looks now:

queryloopinspectorcontrols.mov

[jameskoster]

What do you think @richtabor ?

I noticed some feedback here too: #31158 (comment). Specifically for this control, "Use template’s content selection" was suggested for the default selection.

[richtabor]

Use template’s content selection

I don't think this particular help text assists you with understanding. What's a content selection?

[richtabor]

It's close. Small edits, and a small suggestion for code simplification. I think it'd be fine to land, then revise if needed further. It's certainly an improvement from trunk.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kmanijak <karolmanijak@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[jameskoster]

I think it'd be fine to land, then revise if needed further. It's certainly an improvement from trunk.

Agreed!

[paaljoachim]

Looks good! Thank you @kmanijak Karol!