Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Backport updates from Core #63723

Merged
merged 1 commit into from
Jul 19, 2024
Merged

HTML API: Backport updates from Core #63723

merged 1 commit into from
Jul 19, 2024

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Jul 18, 2024

This PR updates the HTML API files in the 6.6 and 6.7 compat directories. It brings the contents of the 6.7 directory up to commit SHA 7b75c8e.

Note to reviewers: The type annotations added in 6.7 have changed every file in the HTML API, which is why every reference references the _6_7 files and why each file has the corresponding _6_7 file.

@dmsnell dmsnell added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Jul 18, 2024
@dmsnell dmsnell requested review from ockham and sirreal July 18, 2024 23:52
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct and all of the usages of the HTML API seem to be updated correctly.

@dmsnell
Copy link
Member Author

dmsnell commented Jul 19, 2024

@sirreal the end-to-end tests are reliably failing and I see mentions of block bindings and of the button block, both of which rely on the HTML API, so I think something could still be wrong here.

@dmsnell dmsnell force-pushed the html-api/backport-6753 branch from e250af4 to 899947f Compare July 19, 2024 18:36
dmsnell added a commit that referenced this pull request Jul 19, 2024
Updates the HTML API files in the 6.7 compatability layer, bringing
in code that has been merged into Core.
@dmsnell dmsnell force-pushed the html-api/backport-6753 branch from 899947f to cc1905b Compare July 19, 2024 18:37
@dmsnell
Copy link
Member Author

dmsnell commented Jul 19, 2024

@sirreal found a typo on Gutenberg_HTML_Attibute_6_7 and fixed it.

dmsnell added a commit that referenced this pull request Jul 19, 2024
Updates the HTML API files in the 6.7 compatability layer, bringing
in code that has been merged into Core.
@dmsnell dmsnell force-pushed the html-api/backport-6753 branch from cc1905b to a2493c6 Compare July 19, 2024 18:56
dmsnell added a commit that referenced this pull request Jul 19, 2024
Updates the HTML API files in the 6.7 compatability layer, bringing
in code that has been merged into Core.

Co-authored-by: Jon Surrell <sirreal@users.noreply.github.com>
@dmsnell dmsnell force-pushed the html-api/backport-6753 branch from a2493c6 to 54f4d34 Compare July 19, 2024 19:18
Updates the HTML API files in the 6.7 compatability layer, bringing
in code that has been merged into Core.

Co-authored-by: Jon Surrell <sirreal@users.noreply.github.com>
@dmsnell dmsnell force-pushed the html-api/backport-6753 branch from 40b0d82 to 5f9116e Compare July 19, 2024 21:46
@dmsnell dmsnell merged commit 5f9116e into trunk Jul 19, 2024
61 checks passed
@dmsnell dmsnell deleted the html-api/backport-6753 branch July 19, 2024 23:24
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 19, 2024
@priethor priethor added the [Feature] HTML API An API for updating HTML attributes in markup label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants