-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick automation: fix for forks #62900
Conversation
74d73a1
to
66e9903
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Labelling after a merge still works too, but worth noting that labelling after will still not work on forks because this workflow must run on the PR
If this means that we'd have to cherry-pick those manually I think it's fine, but could we add some indication that some PRs are "missing"?
My concern is that the presence of automation in part of the process might relax those in charge of the release if we don't state explicitly that they still have to check the cherry picks.
We anyway still have to check the label (which would be kept). There might be other job runs that failed for some other reason. It happens. At some point I'll update the handbook and I will mention that it's still required to check the label manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: vcanales <vcanales@git.wordpress.org>
What?
This workflow was introduced in #62716, and it generally works well. The problem is that when a PR is merged from a fork, the workflow runs in the context of that fork and lacks the token.
The idea of this PR is to move automation from PRs to pushes. I'll first test this on a
test/trunk
branch.Why?
Because it doesn't currently work for PRs from forks, such as #62857.
How?
Testing Instructions
It works:
test/trunk
branch with this new workflow.Backport to WP 0.0 Beta/RC
, merged it, and it was correctly cherry-picked:Labelling after a merge still works too, but worth noting that labelling after will still not work on forks because this workflow must run on the PR:
Testing Instructions for Keyboard
Screenshots or screencast