Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cover block min height control to use HeightControl #62509

Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update e2e test for cover block
  • Loading branch information
akasunil committed Jun 16, 2024
commit 454f736ff387e37b57407d53df3f2d610d2e20b6
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/blocks/cover.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ test.describe( 'Cover', () => {

// Ensure there the default value for the minimum height of cover is undefined.
const defaultHeightValue = await coverBlockEditorSettings
.getByLabel( 'Minimum height of cover' )
.getByRole( 'slider', { name: 'Minimum height of cover' } )
.inputValue();
expect( defaultHeightValue ).toBeFalsy();

Expand Down
Loading