Page creation and duplication: Decode HTML entities in success notices #62313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +21 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Adds ´@wordpress/html-entities´ to the edit post package.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
commented
Jun 5, 2024
ellatrix
reviewed
Jun 7, 2024
|
Shall we backport this for WP 6.6? Please add the |
|
I added the backport label since the issue doesn't exist in WP 6.5. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
WordPress#62313) * Decode the page title when creating a new page from the Site Editor > Pages * Decode the page title when a page is duplicated from the Data Views * Decode the page title when you duplicate an item in the Edit Site > Editor component * Decode the page title when a page or post is duplicated from the block editor * Add ´@wordpress/html-entities´ to the edit post package. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
|
I manually cherry picked for 6.6 this because there were conflicts. |
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
#62313) * Decode the page title when creating a new page from the Site Editor > Pages * Decode the page title when a page is duplicated from the Data Views * Decode the page title when you duplicate an item in the Edit Site > Editor component * Decode the page title when a page or post is duplicated from the block editor * Add ´@wordpress/html-entities´ to the edit post package. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
ellatrix
added a commit
that referenced
this pull request
Jun 18, 2024
#62313) * Decode the page title when creating a new page from the Site Editor > Pages * Decode the page title when a page is duplicated from the Data Views * Decode the page title when you duplicate an item in the Edit Site > Editor component * Decode the page title when a page or post is duplicated from the block editor * Add ´@wordpress/html-entities´ to the edit post package. Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Decodes HTML entities in the post and page titles in the success notices that shows when creating a new page through the Site Editor, and when duplicating a post or page via the Site Editor Pages screen or the block editor.
Note: This meant adding "@wordpress/html-entities" to the edit-post package.
Partial for #60995
Replaces #61086
Why?
When a page or post title has HTML entities like & in the post title, these success notices displayed the characters as encoded. So & displayed as
&.How?
Wrap the titles inside
decodeEntitieshttps://developer.wordpress.org/block-editor/reference-guides/packages/packages-html-entities/#decodeentitiesTesting Instructions
Screenshots or screencast