-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Modules: Adjust filter and ID #62170
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/script-modules.php |
4b4db3a
to
d8c0e58
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…62170) Update the Script Module data filter name and script tag ID to align with Core changes. See WordPress/wordpress-develop#6682. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Update the Script Module data filter name and script tag ID to align with Core changes. See WordPress/wordpress-develop#6682. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
I just cherry-picked this PR to the release/18.5 branch to get it included in the next release: 2fe4dfa |
I added the Backport to WP Beta/RC label here. The only backport necessary is the |
Update the Script Module data filter name and script tag ID to align with Core changes. See WordPress/wordpress-develop#6682. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Update the Script Module data filter name and script tag ID to align with Core changes. See WordPress/wordpress-develop#6682. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
…62170) Update the Script Module data filter name and script tag ID to align with Core changes. See WordPress/wordpress-develop#6682. Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
This was cherry-picked to the wp/6.6 branch. |
What?
Update the Script Module data filter and script tag ID to align with WordPress/wordpress-develop#6682.
This feature was just implemented in Gutenberg and not yet released, but Core feedback has suggested some changes to the filter name and script tag ID used.
Why?
If the initial version uses the filter and script tag IDs that will ultimately be used in Core, it should save work in the future.