Add badge to title for posts & front pages #61718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I've just given this a quick shot and this is the current status:
I have to go for lunch, will iterate on styles later. Pushed my ongoing work so anyone can push directly — you're always welcome, but specially today with my current time-constraints :) |
33 tasks
|
Size Change: +195 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Pushed some styling changes and it now looks better:
|
youknowriad
reviewed
May 16, 2024
| </Link> | ||
| ) : ( | ||
| decodeEntities( item.title?.rendered ) || | ||
| __( '(no title)' ) | ||
| <> |
There was a problem hiding this comment.
I think an HStack instead of a fragment here might allow better spacing (a small gap or could also allow to use space-between if needed)
I noticed that for long titles, the badge can be "cut" or "hidden". I wonder if the ellipsis should be added to the title only (excluding the suffix) |
|
The remaining two challenges:
|
c4e2af0 to
078d1e5
Compare
|
The current status, accounting for long titles:
|
|
Given my time-constraints, I leave two suggestions for follow-ups (also happy if anyone wants to own this PR and do the tweaks here):
|
|
@oandregal mind if I push a couple small CSS tweaks |
Please, be welcome to do so! 🙇 |
youknowriad
reviewed
May 16, 2024
| @@ -273,6 +273,16 @@ export default function PagePages() { | |||
| [ totalItems, totalPages ] | |||
| ); | |||
|
|
|||
| const { frontPageId, postsPageId } = useSelect( ( select ) => { | |||
There was a problem hiding this comment.
Potential follow-up: I think this one can potentially move to the "render" function instead (or should I say render component) (we should treat them as component in DataViews first though) which will make sure it only runs if the field is actually rendered.
There was a problem hiding this comment.
Title is always rendered in pages, so it would be the same..
There was a problem hiding this comment.
Yes, but still :) conceptually it makes sense for this to be within the field.
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
May 27, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57763
What?
Adds a badge to indicate that a page is the
Front Pageor thePosts Page.Why?
This is the target design we want:
How?
Update the
titlerendering function to check whether the item is one of the special pages. If so, add a badge.Testing Instructions