Fix: Do not show pattern and template actions on the post editor. #60568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +28 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
I don't really understand this, patterns and templates are already editable in the post editor, so why are we doing this? |
Some of the actions that we were showing like "view post" don't work for patterns and templates. With #60395 merged we can start showing again the actions for templates with actions that make sense there like revert template etc. |
Makes sense, so it's not really specific to the post editor.
👍 |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…Press#60568) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are showing generic post actions on templates and patterns in the post editor. Some of these actions don't make sense (e.g. view post), we should hide these actions until template and pattern actions are ported to the editor module making them available on edit post too.
Testing Instructions for Keyboard
Edit a sync pattern on the post editor (e.g: add a sync pattern and then click edit original) and verify no actions are available on the top of the right sidebar.
Edit a template on the post editor and verify no actions are available on the top of the right sidebar.