Global Styles: Remove letter-spacing from typography element preview #60322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6aa7d41. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9763539296
|
5e48264 to
6aa7d41
Compare
creativecoder
approved these changes
Jul 3, 2024
|
@creativecoder Thanks for the review!
For now, this is intentional because there is enough horizontal space and I believe all typography styles should be reflected in the preview. This is also true for the block preview. However, there is overflow when extreme
|
Thanks for clarifying. I agree, I think keeping the preview as close as possible to the actual font display is best. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…ordPress#60322) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the letter-spacing style in the global styles Typography > Elements panel.
Why?
This preview should reflect the actual font style as much as possible, but I think
letter-spacingis unnecessary as it causes unintended layout disruption.How?
Removed
letter-spacingfrom preview styles. This does not affect the preview when accessing Global Styles > Typography > Text.Testing Instructions
letter-spacingstyle.