Background block supports: move size defaults to hooks and block.json #60008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty values from the style engine to a useBlockProps hook. The style engine can now generate "pure" styles, with return values reflecting input values, and not be opinionated or return feature-specific mutations.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +180 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
This is testing nicely for me, thanks for including the quick test markup!
Because it's removing the style engine logic, this PR also affects the default behaviour of theme.json site-wide background images. It won't fill in defaults. Given that #59889 is removing these defaults anyway, then it's a known and expected outcome.
That sounds reasonable to me. Also, if we do want to reuse the defaults here in the future for any reason, we could always split out parts of the innards of this useBlockProps hook and put it in a utility function that global styles can use. We might want to end up doing something like that when it comes to enabling at the block-level within global styles, but that'd be for another PR when it comes to that 🙂
LGTM! ✨
|
Thank you for testing! 🍺
Yes, great idea. I think another big cleanup and test opportunity will be when we return to: |
71 tasks
ramonjd
added a commit
that referenced
this pull request
Mar 20, 2024
ramonjd
added a commit
that referenced
this pull request
Mar 20, 2024
ramonjd
added a commit
that referenced
this pull request
Mar 21, 2024
…ender_background_support and revert gutenberg_get_background_support_styles (#59889) * Move block support defaults to gutenberg_render_background_support and revert gutenberg_get_background_support_styles * Revert JS changes, moving them to a new PR #60008 * background-size auto is the same as no background-size * Using style engine in theme json class to generate background styles because background image can be a string or an object. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…erty values from the style engine to a useBlockProps hook. (WordPress#60008) The style engine can now generate "pure" styles, with return values reflecting input values, and not be opinionated or return feature-specific mutations. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ender_background_support and revert gutenberg_get_background_support_styles (WordPress#59889) * Move block support defaults to gutenberg_render_background_support and revert gutenberg_get_background_support_styles * Revert JS changes, moving them to a new PR WordPress#60008 * background-size auto is the same as no background-size * Using style engine in theme json class to generate background styles because background image can be a string or an object. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? How?
Split from #59889
This commit moves the logic that sets the default background CSS property values from the style engine to a
useBlockPropshook.The style engine can now generate "pure" styles, with output values reflecting input values, and not be opinionated or return feature-specific mutations. This might be handy for global styles, where background defaults aren't required for body tag background images.
Important
Because it's removing the style engine logic, this PR also affects the default behaviour of theme.json site-wide background images. It won't fill in defaults. Given that #59889 is removing these defaults anyway, then it's a known and expected outcome.
Testing Instructions
There should be no regressions in the way background images work in the editor.
When adding a background image to a group block, the default background size should be "cover". Example HTML:
When the background size is set to "contain", the default background position should be "center":
Screenshots or screencast
2024-03-20.10.32.18.mp4