Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Release v1.114.0 #59461

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Mobile Release v1.114.0 #59461

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d306607
Release script: Update react-native-editor version to 1.114.0
Feb 29, 2024
1212c9f
Release script: Update CHANGELOG for version 1.114.0
Feb 29, 2024
2198346
Release script: Update podfile
Feb 29, 2024
971081f
fix: Restore Xcode 15 patch
Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/react-native-aztec/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-aztec",
"version": "1.112.0",
"version": "1.114.0",
"description": "Aztec view for react-native.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-bridge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-bridge",
"version": "1.112.0",
"version": "1.114.0",
"description": "Native bridge library used to integrate the block editor into a native App.",
"private": true,
"author": "The WordPress Contributors",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ For each user feature we should also add a importance categorization label to i
-->

## Unreleased

## 1.114.0
- [*] Prevent crash when autoscrolling to blocks [#59110]
- [*] Remove opacity change when images are being uploaded [#59264]
- [*] Media & Text blocks correctly show an error message when the attached video upload fails [#59288]
Expand Down
12 changes: 2 additions & 10 deletions packages/react-native-editor/ios/GutenbergDemo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,11 +706,7 @@
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
OTHER_LDFLAGS = "$(inherited)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this change is showing up for the release? It looks like it's also there in the Gutenberg Mobile PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some of the changes that happened in this PR are being reverted, but I'm not sure why.

I added the removed lines back locally then ran bundle exec pod install --repo-update, and they were removed again with the following warning:

[!] The `GutenbergDemo [Debug]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.debug.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

[!] The `GutenbergDemo [Release]` target overrides the `LIBRARY_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-GutenbergDemo/Pods-GutenbergDemo.release.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

So, it seems like these changes may be correct. @fluiddot, does this seems right to you, as the author of the original changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the Xcode project are related to this commit from React Native. AFAIK it's a patch for Xcode 15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB Not sure why they are getting reverted, I can try to install the pods locally and see if I get the same modifications.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB Are you using Xcode 15? If not, maybe that could be the reason why they are being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I'm on Xcode 15.2. 🤔 Are they not removed when you run bundle exec pod install --repo-update locally?

Copy link
Contributor Author

@SiobhyB SiobhyB Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, when I ran xcodebuild -version in the command line, I get 13.4.1. I'll figure out how to update that now...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running bundle exec pod install --repo-update locally and the Xcode project remains unmodified. @SiobhyB I wonder what's the difference in our setup. Could you check the React Native version installed in your local environment?

You can quickly check the version by running cat node_modules/react-native/package.json | jq '.version' in Gutenberg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, when I ran xcodebuild -version in the command line, I get 13.4.1. I'll update now...

That might be the issue, yeah try changing the Xcode selection to use 15.2

I've run bundle exec pod install --repo-update and I don't see any changes locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran sudo xcode-select --switch /Applications/Xcode.app to update locally, then bundle exec pod install --repo-update produced the correct results. I've gone ahead to update in 971081f. I'll update Gutenberg Mobile now, too.

Thank you @geriux and @fluiddot! 🙌

REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -751,11 +747,7 @@
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
OTHER_LDFLAGS = "$(inherited)";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_VERSION = 5.0;
Expand Down
8 changes: 4 additions & 4 deletions packages/react-native-editor/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ PODS:
- ReactCommon/turbomodule/core (= 0.71.15)
- fmt (6.2.1)
- glog (0.3.5)
- Gutenberg (1.112.0):
- Gutenberg (1.114.0):
- React-Core (= 0.71.15)
- React-CoreModules (= 0.71.15)
- React-RCTImage (= 0.71.15)
Expand Down Expand Up @@ -429,7 +429,7 @@ PODS:
- React-RCTImage
- RNSVG (13.9.0):
- React-Core
- RNTAztecView (1.112.0):
- RNTAztecView (1.114.0):
- React-Core
- WordPress-Aztec-iOS (= 1.19.9)
- SDWebImage (5.11.1):
Expand Down Expand Up @@ -617,7 +617,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 8f5ee005451bf28f6a3ae995914b2f04b3584122
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
Gutenberg: fad00864ab916e9f7778e5493c1a7f3bd9316eb4
Gutenberg: 3f546b663d6776141e069f4fb505428009e4e59a
hermes-engine: 04437e4291ede4af0c76c25e7efd0eacb8fd25e5
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
libwebp: 60305b2e989864154bd9be3d772730f08fc6a59c
Expand Down Expand Up @@ -662,7 +662,7 @@ SPEC CHECKSUMS:
RNReanimated: d4f363f4987ae0ade3e36ff81c94e68261bf4b8d
RNScreens: 68fd1060f57dd1023880bf4c05d74784b5392789
RNSVG: 53c661b76829783cdaf9b7a57258f3d3b4c28315
RNTAztecView: 74c676c87e4a9db79104fcdad9624c1e5c02fe15
RNTAztecView: 68c970e04c9f7ae81ba64810667a07a66e6ba0b7
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImageWebPCoder: 908b83b6adda48effe7667cd2b7f78c897e5111d
WordPress-Aztec-iOS: fbebd569c61baa252b3f5058c0a2a9a6ada686bb
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wordpress/react-native-editor",
"version": "1.112.0",
"version": "1.114.0",
"description": "Mobile WordPress gutenberg editor.",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down
Loading