Zoomed-Out Mode: Don't show blocks in zoomed out view #59245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbca834 to
4793bd6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
|
Size Change: +53 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
priethor
approved these changes
Feb 21, 2024
|
Should we hide |
|
What happens when the theme has disabled Core patterns and does not register any of its own? |
In that case, what would be the difference between hiding the blocks or not? Wouldn't there be zero blocks to hide? |
Good catch, it can lead to inserting an image block. |
|
It'd be great to hide the tab bar completely :) |
I see that Zoomed In Mode is only designed to support the insertion of patterns, not individual blocks. So, if there are no patterns, what happens? Is the inserter just disabled? Or should Zoomed In Mode be disabled? |
|
The media tab gets hidden now, too: Grabacion.de.pantalla.2024-02-21.a.las.16.53.50.mov |
|
Flaky tests detected in 6349a77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7991835005
|
Test ReportThis report validates that the PR addresses the issue.Patch tested: #59245 Environment
Actual results
|
scruffian
commented
Feb 21, 2024
|
I think we need to disable zoom out mode if there are no patterns |
jeryj
requested changes
Feb 24, 2024
14de6f4 to
25121d0
Compare
|
Just swapping the type label out for "Type Enhancement" for the GB 17.9 changelog since this feature stood out a bit. Feel free to switch it back if you'd prefer, though! |
scruffian
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit d727cb4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If we are in zoomed out view we shouldn't show blocks in the inserter.
Why?
Zoomed out mode is used for editing your pages and templates at a high level, not for adding single blocks.
How?
Testing Instructions
Screenshots or screencast