Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'All pages' view label consistent with template and patterns #59009

Merged
merged 4 commits into from
Feb 16, 2024
+2 −2
Merged

Make 'All pages' view label consistent with template and patterns #59009

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a8f20
Make 'All pages' view label consistent with template and patterns
jameskoster Feb 14, 2024
3595e9e
Use __()
jameskoster Feb 14, 2024
cd33f15
Merge branch 'trunk' into update/all-pages-view-title
jameskoster Feb 15, 2024
1b245be
Merge branch 'trunk' into update/all-pages-view-title
jameskoster Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar-dataviews/default-views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const DEFAULT_PAGE_BASE = {
export const DEFAULT_VIEWS = {
page: [
{
title: _x( 'All', 'pages' ),
title: _x( 'All pages', 'pages' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: _x( 'All pages', 'pages' ),
title: __( 'All pages' ),

Context may no longer be necessary.

Note: If you apply this suggestion, you will also need to remove _x from the import statement to pass the lint check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, good suggestion :)

slug: 'all',
view: DEFAULT_PAGE_BASE,
},
Expand Down
Loading