-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove left margin on Status help text #58775
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -6 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This margin was added in #51408, but as you can see in the screenshot of this PR, the help text is left-aligned. At the time this PR was submitted, this margin may have been necessary for left alignment.
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: e109bed |
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Note that as part of curating the Gutenberg 17.8 changelog, I added the label "[Package] Edit Site" to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
What?
Remove style override:
margin-left
applied to.edit-site-change-status__content .edit-site-change-status__options label .components-text
.Why?
The current display is broken:
After
Testing Instructions
Note: I think this panel could use some more polishing – the spacing and alignment in particular, but that will likely lead to touching the
RadioControl
, so is best explored separately. The purpose of this PR is only to fix the broken display.