Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n: Make block preview title translatable #5861

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

Soean
Copy link
Member

@Soean Soean commented Mar 28, 2018

Description

This PR adds i18n for the Preview title of the block preview component.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Mar 28, 2018
@aduth
Copy link
Member

aduth commented Mar 28, 2018

Testing instructions: This label in Inserter > Shared:

Preview

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aduth aduth merged commit 7a0150b into master Mar 28, 2018
@aduth aduth deleted the update/i18n-editor-block-preview branch March 28, 2018 23:50
@aduth
Copy link
Member

aduth commented Mar 28, 2018

Actually, while I just merged, one potential issue here is disambiguation of the word "Preview" . Is it a noun or a verb? Good for _x context.

https://codex.wordpress.org/I18n_for_WordPress_Developers#Disambiguation_by_context

@Soean
Copy link
Member Author

Soean commented Mar 29, 2018

@aduth Thanks, maybe a context is better for some languages. In the preview component it is a noun on the button a verb. In german we have no verb for preview. So we use the noun "Vorschau" for both. I will open another PR.
Or should we wait until this context is needed for a specific language?

@Soean Soean added this to the 2.6 milestone Mar 29, 2018
@aduth
Copy link
Member

aduth commented Apr 3, 2018

My understanding is context is good to provide anytime there's the potential for ambiguity (here, on part of speech).

In any case, here's an actual example:

https://translate.google.com/#en/es/preview

noun
  | el | avance | advance, progress, development, preview, lead, trailer
  | el | preestreno | preview
  | la | vista anticipada | preview
verb
  | preestrenar | preview
  | presentar a los críticos | preview, press view
  | ver antes que los demás | preview, press view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants