Updates Font Families and Font Faces endpoints context param #58287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController.php |
This was referenced Jan 25, 2024
matiasbenedetto
approved these changes
Jan 26, 2024
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 7529726 |
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
wp/v2/font-familiesandwp/v2/font-families/<id>/font-facesendpointscontextparamcontextto view, to be consistent with other Core endpointsview,edit, andembed, since viewing, editing, and embedding are valid contexts for both objectsWhy?
As pointed out by @matiasbenedetto here, the context param seems to be not about where the request is being called from (front-end vs. editor), but about what information is needed to take a specific action on the object.
How?
Updates the endpoint schema and defaults.
Testing Instructions
view,edit,embedand no value for?context=GET wp/v2/font-familiesGET wp/v2/font-familiesGET wp/v2/font-families/<id>/font-facesGET wp/v2/font-families/<id>/font-faces/<id>OPTIONSrequests to see that thecontextparam correctly defaults toviewand accepts any of those three contexts as valid