DataViews: Fix author sorting in templates and template parts #58167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Jan 24, 2024
| @@ -374,7 +374,7 @@ export default function PageTemplatesTemplateParts( { postType } ) { | |||
| data: filteredData, | |||
| view, | |||
| fields, | |||
| textFields: [ 'title' ], | |||
| textFields: [ 'title', 'author' ], | |||
There was a problem hiding this comment.
I think this can work for now, but we could follow-up to do the following:
- add
texttype to fields - remove
textFieldsfromsortByTextFields
There was a problem hiding this comment.
Now that I look at this utility, sortByTextFields can probably become sortByField with more type field info.
There was a problem hiding this comment.
It's not that straightforward right now because author is an type:enumeration. Maybe we could explore if we could use getValue for those fields too, but we would need to think of what other use cases we could have..
There was a problem hiding this comment.
I agree with removing textFields. It's true that not all enums behave like regular text fields, but we can approach this more generally. Also, is sort-by-author currently sorting by the username? What about display name?
There was a problem hiding this comment.
For templates and template parts we use the author_text, which is a custom implementation due to the different kind of authors. For example for theme items the actual persisted value in db is author:0, but we extract the theme name as author.
oandregal
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #57978
Testing Instructions