Rich text: avoid block editor subscription if not selected #57226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +20 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 20, 2023
| if ( ! isBlockSelected ) { | ||
| return { isSelected: false }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Some of the "if" checks under this can be simplified now no?
There was a problem hiding this comment.
I don't think so? It checks if the rich text instance is selected, it doesn't involve the block selection check
youknowriad
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While this does not remove a
useSelectcall per block, it should remove a subscription to the bock editor store per block.Why?
1st run: -8.4% (type)
2nd run: -3.0%
3rd: -6.2%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast