StartPageOptions: improve conditions to show modal only on a brand new page #54245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7.54 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Th editor package has selector that checks if it’s a new post/page. I think the PostTitle component uses it to set focus on newly created content. What do you think about using that selector? Sorry, I’m AFK at the moment so can’t search the codebase. Found it: https://github.com/WordPress/gutenberg/blob/trunk/packages/editor/src/store/selectors.js#L151 |
Good idea! Its name is |
jorgefilipecosta
approved these changes
Sep 8, 2023
|
Nice job! |
|
Thank you, @jsnajdr! As a follow-up, it would be nice to introduce e2e tests for this feature. It's not widely adopted to get regression reports from the users, but it is also good to catch them early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54227.
The condition that inspects the current post, and triggers displaying the pattern selection modal, it was wrong. It fired also in two cases where it shouldn't fire:
See the comments in #54227 for more details.
The fix improves the condition in several ways:
isEditedPostSaveableselector, check explicitly thetitle,excerptandcontentattributes of the postisEditedPostSaveable, we're not evaluating theisSavingPostcondition (is save in progress?) which is irrelevant for usisEditedPostEmptyto detect empty content in a more optimized way -- ifpost.contentis a function, we no longer call it all the timeisEditedPostDirtyto verify that the post is brand new, and not just an edit of existing non-empty postHow to test:
Verify that the patterns modal is shown when it should be (when creating a new page), and that it's not shown in the two reported cases: