EditPostPreferencesModal: refactor to remove snapshots for index.js #54141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1f607d to
865aecb
Compare
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
…anges when the viewport width changes (show toggle inputs vs don't)
andrewserong
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Looks good to me! It might be worth confirming with @ntsekouras or others if there were any other reasons that snapshot tests were used for this component, over testing for the visibility of particular child components as in this PR. Personally, in general, I much prefer tests like in this PR, as it makes it clearer what's being tested for, and is less prone to fail due to side effects.
Since it sounds like this will help unblock things on trunk, this LGTM to merge, and we can always roll back if it turns out that the snapshots were needed for other aspects of the test coverage (or add additional tests for what needs to be covered).
Thanks for this!
jsnajdr
reviewed
Sep 4, 2023
|
Thanks for confirming, Jarda! |
No specific reasons.. These tests look fine, thank you for handling that! |
|
Thanks for double-checking everyone! 🙇🏻 |
|
I've noticed similar failures (Modal or Popover related) with |
I saw those too. The opacity changes on the inline styles. I wasn't sure if it was related to the aria-kit changes or not, but maybe there's scope to remove the snapshot there too. |
|
@Mamaduka I have a PR up to fix that test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Every second or third run, I'm seeing the following errors in both local and CI JS unit tests
This PR already tried to fix this test:
Historical context: #52133 (comment)
Instead of waiting around for aria-kit to add the tab-index attribute, this PR just gets rid of the relevant snapshot, and, rather, tests for main view elements to verify that the viewport switch is made. Thanks to @andrewserong for helping to debug
The snapshots seem to only test whether
useViewportMatchrenders the correct views. By testing for some key elements we don't need the entire snapshot.There's also a strong argument to turn this into an E2E test, but for now, I'm just getting the tests to pass to unblock folks.
How are you?
All good here, thanks!
Testing Instructions
Check CI
npm run test:unit packages/edit-post/src/components/preferences-modal/test/index.jsuntil you get sick of it