Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML API: Backport updates from Core - stop processing after unsupported markup #53878

Closed
wants to merge 1 commit into from
Closed

HTML API: Backport updates from Core - stop processing after unsupported markup #53878

wants to merge 1 commit into from

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Aug 22, 2023 •
edited
Loading

Description

WordPress/wordpress-develop#5048 fixes a bug where the HTML Processor continues to process input HTML once it encounters unsupported markup, which it shouldn't. It should stop and abort all processing.

As a blessed PR, once this is merged into Core it should need no further review here other than to make sure that the backport was properly written and applied.

@dmsnell dmsnell added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup labels Aug 22, 2023
@WordPress WordPress deleted a comment from github-actions bot Aug 22, 2023
@github-actions
Copy link

Flaky tests detected in 3f59dab.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5942111667
📝 Reported issues:

@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core--stop-at-unsupported-html branch from 3f59dab to d7c011c Compare September 1, 2023 20:55
@dmsnell dmsnell marked this pull request as ready for review September 1, 2023 20:57
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php

@dmsnell
HTML API: Backport updates from Core - stop processing after unsuppor…
9298814 
…ted markup

WordPress/wordpress-develop#5048 fixes a bug where the HTML Processor continues
to process input HTML once it encounters unsupported markup, which it shouldn't.
It should stop and abort all processing.
@dmsnell dmsnell requested a review from ockham September 5, 2023 20:03
@dmsnell dmsnell force-pushed the html-api/backport-updates-from-core--stop-at-unsupported-html branch from d7c011c to 9298814 Compare September 5, 2023 20:04
@dmsnell
Copy link
Member Author

dmsnell commented Sep 19, 2023

Folding into #54481

@dmsnell dmsnell closed this Sep 19, 2023
@dmsnell dmsnell deleted the html-api/backport-updates-from-core--stop-at-unsupported-html branch September 19, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@ockham ockham Awaiting requested review from ockham

Assignees
No one assigned
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] HTML API An API for updating HTML attributes in markup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmsnell