Data: Introduce countSelectorsByStatus redux metadata selector
#53767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +456 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 6, 2023
a15e98e to
7a1076b
Compare
jsnajdr
reviewed
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new
countSelectorsByStatus()redux metadata selector that groups and returns the number of selectors per status.Why?
Necessary for implementing a determinate progress bar in #53399.
How?
We're counting the selectors similar to how we're doing it in the existing
hasResolvingSelectors()and grouping them before returning them.Since there are similarities between how we're accessing the private parts of the underlying
EquivalentKeyMapwith how we're doing it inhasResolvingSelectors, I'm considering following up with some polishing after landing.We're also adding some unit tests.
Testing Instructions
Verify tests pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None