-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Widget: Fix content cutoff in the keyboard shortcut modal #53638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Feature] Shortcodes
Related to shortcode functionality
[Package] Edit Widgets
/packages/edit-widgets
and removed
[Feature] Shortcodes
Related to shortcode functionality
labels
Aug 14, 2023
t-hamano
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
August 14, 2023 14:08
Size Change: -38 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Edit Widgets
/packages/edit-widgets
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a problem in the Block Widget Editor where text in the keyboard shortcut modal is cut off.
Before
After
Why?
This is because a negative margin was applied to the top of the main shortcut section. A similar style existed in the post editor and the site editor but was removed when the modal design was updated in #40781. Therefore, this style is also unnecessary in the widget editor.
Testing Instructions