Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick bugfixes for 6.3.2 #53623

Merged
merged 22 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
79e56b6
Update document title buttons radius (#53221)
jameskoster Aug 2, 2023
0524c65
Fix: Sync status overlaps for some languages in Patterns post type pa…
t-hamano Aug 3, 2023
3a9178a
Image block: Fix stretched images constrained by max-width (#53274)
ajlende Aug 3, 2023
d564a13
Image Block: Don't render `DimensionsTool` if it is not resizable (#5…
t-hamano Aug 4, 2023
baefb67
Fix missing Replace button in content-locked Image blocks (#53410)
noisysocks Aug 8, 2023
cc90b61
fix the go to for non pages by showing it only for pages (#53408)
draganescu Aug 8, 2023
340df75
Site Editor: Fix document actions label helper method (#52974)
Mamaduka Aug 9, 2023
3f0c87a
Image: Clear aspect ratio when wide aligned (#53439)
ajlende Aug 9, 2023
2c25cd2
RichText: Remove 'Footnotes' when interactive formatting is disabled …
Mamaduka Aug 10, 2023
6e1ddbf
Preserve block style variations when securing theme json (#53466)
dsas Aug 11, 2023
e46b446
Site editor: add missing i18n in `HomeTemplateDetails` (#53543)
swissspidy Aug 11, 2023
4c487cd
Fix: Snack bar not fixed on certain pages in the Site Editor (#53207)
tellthemachines Aug 14, 2023
1cb6459
Fix document title alignment in command palette button (#53224)
jameskoster Aug 2, 2023
96b6b1e
Fallback to default max viewport if layout wide size is fluid. (#53551)
tellthemachines Aug 11, 2023
d5275a5
Link Control: persist advanced settings toggle state to preferences i…
scruffian Aug 2, 2023
7605074
Add tests for fluid layout + typography (#53554)
tellthemachines Aug 11, 2023
c81f322
Fix support of sticky position in non-iframed post editor (#53540)
stokesman Aug 15, 2023
0139ded
Revert "Footnotes: Fix recursion into updating attributes when attrib…
tellthemachines Aug 16, 2023
093496a
Fix: indicator style when block moving mode (#53972)
t-hamano Aug 29, 2023
7f41dd3
Fix post editor top toolbar with custom fields in Safari (#53688)
draganescu Aug 15, 2023
6ae0c48
Set top toolbar size dynamically (#53526)
draganescu Aug 15, 2023
d67ed5e
Roll back camelCase change in 96b6b1e
ramonjd Aug 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RichText: Remove 'Footnotes' when interactive formatting is disabled (#…
…53474)

Introduce a new 'interactive' setting for format types
  • Loading branch information
Mamaduka authored and tellthemachines committed Aug 31, 2023
commit 2c25cd2671ea57ebe3f34d5a6e8ddeab3584867c
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,21 @@ export function useFormatTypes( {
} ) {
const allFormatTypes = useSelect( formatTypesSelector, [] );
const formatTypes = useMemo( () => {
return allFormatTypes.filter( ( { name, tagName } ) => {
return allFormatTypes.filter( ( { name, interactive, tagName } ) => {
if ( allowedFormats && ! allowedFormats.includes( name ) ) {
return false;
}

if (
withoutInteractiveFormatting &&
interactiveContentTags.has( tagName )
( interactive || interactiveContentTags.has( tagName ) )
) {
return false;
}

return true;
} );
}, [ allFormatTypes, allowedFormats, interactiveContentTags ] );
}, [ allFormatTypes, allowedFormats, withoutInteractiveFormatting ] );
const keyedSelected = useSelect(
( select ) =>
formatTypes.reduce( ( accumulator, type ) => {
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/footnotes/format.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export const format = {
attributes: {
'data-fn': 'data-fn',
},
interactive: true,
contentEditable: false,
[ usesContextKey ]: [ 'postType' ],
edit: function Edit( {
Expand Down
1 change: 1 addition & 0 deletions packages/rich-text/src/register-format-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { store as richTextStore } from './store';
* unique across all registered formats.
* @property {string} tagName The HTML tag this format will wrap the
* selection with.
* @property {boolean} interactive Whether format makes content interactive or not.
* @property {string} [className] A class to match the format.
* @property {string} title Name of the format.
* @property {Function} edit Should return a component for the user to
Expand Down