Compat: Remove unnecessary api-request shim #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d7fad0 to
9113c99
Compare
youknowriad
reviewed
Feb 19, 2018
lib/compat.php
Outdated
| $wp_api_localized_data = $wp_scripts->get_data( 'wp-api', 'data' ); | ||
| if ( false !== $wp_api_localized_data ) { | ||
| wp_add_inline_script( 'wp-api-request', $wp_api_localized_data, 'before' ); | ||
| function gutenberg_fix_jetpack_freeform_block_conflict() { |
There was a problem hiding this comment.
Any particular reason to bring this back? or is this just a rebase issue?
There was a problem hiding this comment.
Oops, yes, this was a bad rebase. Let me redo.
There was a problem hiding this comment.
Corrected in rebased 60e1e0d.
Added in WordPress 4.9
9113c99 to
60e1e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #4762
Related: #4950 (WordPress support explicitly updated)
This pull request seeks to remove the api-request JavaScript shim which had existed while WordPress 4.9 was in pre-release, in order to support the 4.8 stable release at the time. Since WordPress 4.9.x is now stable, this shim can now be removed. This effectively increases the minimum WordPress version supported by the Gutenberg plugin to 4.9.0.
Testing instructions:
Verify that the editor loads as expected, particularly that the api-request file is loaded correctly from the WordPress installation.