Adopt lock-unlock.js and private-apis.js convention #51322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jun 8, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Always put lock and unlock functions in a file called lock-unlock.js * Rename lockUnlock.js to lock-unlock.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates every package so that the
lockandunlockfunctions are always in a file calledlock-unlock.jsand exported private APIs are always in a file calledprivate-apis.js.Why?
Some packages already have this convention and some packages do not. This PR makes it consistent. It's really frustrating when writing code to have to look up where the function is declared every time that you want to import
unlockto use a private API.How?
Find and replace.
Testing Instructions
Smoke test all of the editors to see if there are any console errors.