Move action-binding code to a bindAction function #51161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 230b101. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5143597539
|
youknowriad
approved these changes
Jun 1, 2023
adamziel
reviewed
Jun 14, 2023
| ); | ||
| function bindAction( action ) { | ||
| return ( ...args ) => | ||
| Promise.resolve( store.dispatch( action( ...args ) ) ); |
There was a problem hiding this comment.
Does it not turn synchronous results into promises? Or does dispatch always return a promise?
There was a problem hiding this comment.
Yes, dispatch always returns a promise, for historical reasons. I would love to get rid of that, because it doesn't make much sense -- not all actions are async. But that would break code like dispatch( foo ).bar().then( ... ).
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the
mapActionsfunction, a spinoff from #51051. Which will build on these changes and implement returning stable references to private actions fromdispatch, and exposing private actions to thunks.The
mapActionsfunction is removed in favor of callingmapValues( actions, bindAction )directly. And in the private action proxy, we map only the one action that the getter is requesting, not all of them.