Link Control test migration: Should contain a label when it should open in a new tab #51001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d3665f to
fabeb11
Compare
|
Flaky tests detected in 084740d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5091216065
|
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
3926038 to
26ca583
Compare
getdave
reviewed
May 26, 2023
getdave
reviewed
May 26, 2023
65d02c1 to
084740d
Compare
0ff31a9 to
9d3e062
Compare
3a53923 to
7431fe3
Compare
|
This can get another review now, updated with the same improvements as #50996 |
kevin940726
approved these changes
May 29, 2023
| await page.keyboard.type( 'w.org' ); | ||
|
|
||
| await page | ||
| .locator( '.block-editor-link-control' ) |
| // Navigate back to inputs to verify appears as changed. | ||
| await pageUtils.pressKeys( 'primary+k' ); | ||
| const urlInputValue = await page | ||
| .getByPlaceholder( 'Search or type url' ) |
There was a problem hiding this comment.
Nit: I wonder if we could use getByRole here? I think either is fine though 👍 .
09d9f56 to
2514e49
Compare
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…en in a new tab (WordPress#51001) * fixed utils * update snapshots, commented waitForURLFieldAutoFocus * remove appender function * removed snapshots * migrated test * removed old test * removed old snapshots * use proper locator instead of a class * use locators instead of tabbing around, remove appender util function * simplified test * removed snapshots and updated locator of save button * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #50995
Based on top of #50996
This Pr needs to wait for the previous one to get merged since we didn't have any playwright tests for this component yet, it needed that setup.
This PR migrates the test "Should contain a label when it should open in a new tab" for the link control component to playwright
Why?
In an effort to migrate our e2e tests to use playwright, we've decided to pick up some of the tests for this component as we work on it to improve it, instead of trying to maintain the puppeteer tests.
How?
Following the guidelines for e2e tests migrations
Testing Instructions
run
npm run test:e2e:playwright -- -g "Should contain a label when it should open in a new tab"and the test should pass