Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated Nav block functions to bottom of render file #50328

Merged

Conversation

getdave
Copy link
Contributor

@getdave getdave commented May 4, 2023

What?

Deprioritises the deprecated Nav block render functions by moving to bottom of file

Closes #49998

Why?

We were going to use a seperate file (as in #49998) but that doesn't get compiled into the build. So moving them to the bottom seems like the best way to reduce their "noise" and deprioritise them.

How?

Moves all the deprecated functions to the end of the file.

Testing Instructions

Check existing functionality still works.

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels May 4, 2023
@getdave getdave self-assigned this May 4, 2023
@getdave getdave requested a review from tellthemachines as a code owner May 4, 2023 11:51
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scruffian scruffian enabled auto-merge (squash) May 4, 2023 12:14
@scruffian scruffian merged commit 8816de1 into trunk May 4, 2023
@scruffian scruffian deleted the update/move-to-deprioritise-deprecated-nav-functions branch May 4, 2023 12:27
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Nav block PHP deprecated functions to separate file
2 participants