Update Reakit dep to 1.3.11 #49763
Merged
Update Reakit dep to 1.3.11 #49763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update popperjs
|
Size Change: +766 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 35fd578. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4680137335
|
Could we remove that declaration for |
Unfortunately no, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49649
What?
Updates
reakitto 1.3.11 (diff, no major changes that might affect us). Also updatespopperjsto 2.11.7 (at the package-json level).Why?
Fixes these TypeScript errors when
skipLibCheck: falsefortsc:Unfortunately I couldn't find a good fix for this duplicate declaration error in a reasonable amount of time, so I'll keep the
skipLibCheck: truefor now:Testing Instructions
✅ Types compile successfully (
npm run build:package-types)