-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment - try adding a shortcut for hiding the block toolbar and outline #49564
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
21ba7fe
Fix hide/show block interface actions not working outside spacing vis…
talldan c7de2a5
Support hiding the block outline
talldan fdbc2d9
Initial implementation
talldan b4ccf82
Fixes to ShortcutProvider and useShortcut
talldan 174c384
Bind to alt
talldan be974aa
Avoid hiding the toolbar while focus is in the toolbar to prevent a f…
talldan 8cef3f3
Support modifier only shortcuts in the keycodes package
talldan 490fcce
Improve description
talldan e243a1a
Properly hide the block outline
talldan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -24,14 +24,22 @@ export function ShortcutProvider( props ) { | |||||
if ( props.onKeyDown ) props.onKeyDown( event ); | ||||||
|
||||||
for ( const keyboardShortcut of keyboardShortcuts.current ) { | ||||||
keyboardShortcut( event ); | ||||||
keyboardShortcut.onKeyDown( event ); | ||||||
} | ||||||
} | ||||||
|
||||||
function onKeyUp( event ) { | ||||||
if ( props.onKeyUp ) props.onKeyUp( event ); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Maybe we could use optional chaining here? |
||||||
|
||||||
for ( const keyboardShortcut of keyboardShortcuts.current ) { | ||||||
keyboardShortcut.onKeyUp( event ); | ||||||
} | ||||||
} | ||||||
|
||||||
/* eslint-disable jsx-a11y/no-static-element-interactions */ | ||||||
return ( | ||||||
<Provider value={ keyboardShortcuts }> | ||||||
<div { ...props } onKeyDown={ onKeyDown } /> | ||||||
<div { ...props } onKeyDown={ onKeyDown } onKeyUp={ onKeyUp } /> | ||||||
</Provider> | ||||||
); | ||||||
/* eslint-enable jsx-a11y/no-static-element-interactions */ | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was accidentally copied from above and could be removed?