[RNMobile] Update Sandbox component resizing handler #49147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converts function to a literal string ( to avoid calling `.toString` ) - Uses `WebView.injectedJavaScript` to inject the resize listeners
jhnstn
commented
Mar 16, 2023
| `(${ observeAndResizeJS.toString() })();`, | ||
| } } | ||
| /> | ||
| { customJS && ( |
There was a problem hiding this comment.
Keeping the ability to inject customJS but I haven't verified if an custom script will work on Android. I'm fine with removing this since it's not verified injecting scripts this way will work.
Instead I can add the customJS override in the injectedJavaScript prop although I'm not sure why we would want the core resize events to be overridden.
There was a problem hiding this comment.
Probably we could also inject the customJS via the injectedJavaScript, instead of adding it to the HTML. Especially if we know that can have issues when running on Android.
Instead I can add the customJS override in the injectedJavaScript prop although I'm not sure why we would want the core resize events to be overridden.
Actually, there's a case for WordPress embeds:
So, I understand that we'll have the same issue on Android for that type of embed.
There was a problem hiding this comment.
In case you want to test a WP embed, you can use the following URL: https://wordpress.org/news/2021/07/tatum/.
There was a problem hiding this comment.
Actually, there's a case for WordPress embeds
Oh awesome, thanks for pointing that out.
So, I understand that we'll have the same issue on Android for that type of embed.
Good news is that custom JS does not call toScript(). It might work in the script tag but since it seems the intent of customJS or at least the expectation is to override the built in resize handler script. Sandbox could probably use a better prop name like observeAndResizeScript but we can save that for another day.
jhnstn
commented
Mar 16, 2023
|
Size Change: +601 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
fluiddot
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
LGTM 🎊 ! Thanks for fixing this @jhnstn 🙇 !
I tested different embeds on both platforms and they were rendered properly, including when rotating the device:
- YouTube:
https://www.youtube.com/watch?v=ssfHW5lwFZg - Vimeo:
https://vimeo.com/278150343 - Twitter:
https://twitter.com/automattic/status/1395447061336711181 - WP embed:
https://wordpress.org/news/2021/07/tatum/
| `(${ observeAndResizeJS.toString() })();`, | ||
| } } | ||
| /> | ||
| { customJS && ( |
There was a problem hiding this comment.
Probably we could also inject the customJS via the injectedJavaScript, instead of adding it to the HTML. Especially if we know that can have issues when running on Android.
Instead I can add the customJS override in the injectedJavaScript prop although I'm not sure why we would want the core resize events to be overridden.
Actually, there's a case for WordPress embeds:
So, I understand that we'll have the same issue on Android for that type of embed.
| `(${ observeAndResizeJS.toString() })();`, | ||
| } } | ||
| /> | ||
| { customJS && ( |
There was a problem hiding this comment.
In case you want to test a WP embed, you can use the following URL: https://wordpress.org/news/2021/07/tatum/.
|
Flaky tests detected in 2fb6eb3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4451051580
|
fluiddot
reviewed
Apr 10, 2023
| // get an DOM mutations for that, so do the resize when the window is resized, too. | ||
| window.addEventListener( 'resize', sendResize, true ); | ||
| window.addEventListener( 'orientationchange', sendResize, true ); | ||
| widow.addEventListener( 'click', sendResize, true ); |
There was a problem hiding this comment.
@jhnstn I've just noticed window is misspelled here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the native
Sandboxcomponent to correctly handle resize events on AndroidWhat?
Updates how the native
Sandboxcomponent injects the resize handling script.Why?
To fix an issue with embeds not resizing correctly on Android: wordpress-mobile/gutenberg-mobile#5565
How?
toString(). Even with theshow sourcedirective, the script was not firing on Android.WebView.injectedJavaScriptto set up the resize handlers in the web view. Again, the script was not running when injected via ascripttag in the wrapper markup.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast