Adjust Post Featured Image PanelBody label to "Settings" #49076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree! BUT... |
|
Size Change: +6 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 241a819. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4419088703
|
Other than anything in block supports/link-related? |
Yes. So that there becomes a need for another panel. |
|
"Settings" seems right to me, as a general drawer for all controls that don't immediately fit into some of the generic panels such as Layout, Border, Advanced, Styles etc. Which is also to say that if we do need to add additional settings to the block which don't fit into any of the generic panels, Settings would be the appropriate generic panel for it. |
|
Tab settings. Ahh I see Image block does it like so.
So for consistency. It seems like the correct move. |
talldan
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
I also thought about the fact that it's a 'settings' section inside a 'settings' tab. Even having a collapsible section seems overkill for simple blocks now that there are tabs that offer context.
Still looks good to move forwards with this as an interim step though.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As the Post Featured Image block only has one settings PanelBody, let's reduce cognitive load and improve consistency between blocks by renaming "Link Settings" to "Settings".
Why?
Consistency.
How?
Just a minor text string change.
Testing Instructions
Screenshots or screencast