Renames parent selection boolean param and improves docs #48677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nik Tsekouras <16275880+ntsekouras@users.noreply.github.com> Co-authored-by: George Mamadashvili <240569+Mamaduka@users.noreply.github.com>
getdave
reviewed
Mar 2, 2023
|
Size Change: -2 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Mar 2, 2023
|
Flaky tests detected in b6ccfa0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4313472016
|
Mamaduka
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thank you, @draganescu!
The fix works as before. Tested using instructions from #48204.
ntsekouras
added a commit
that referenced
this pull request
Mar 7, 2023
* Renames parent selection boolean param and improves docs Co-authored-by: Nik Tsekouras <16275880+ntsekouras@users.noreply.github.com> Co-authored-by: George Mamadashvili <240569+Mamaduka@users.noreply.github.com> * better wording for action docs --------- Co-authored-by: Nik Tsekouras <16275880+ntsekouras@users.noreply.github.com> Co-authored-by: George Mamadashvili <240569+Mamaduka@users.noreply.github.com>
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d99c758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small code quality and documentation PR to improve how #48204 gets merged to core.
Co-authored-by: Nik Tsekouras 16275880+ntsekouras@users.noreply.github.com
Co-authored-by: George Mamadashvili 240569+Mamaduka@users.noreply.github.com
What?
Rename the param to optionally select parent block of the
selectPreviousBlockaction tofallbackToParentMake docs more explicit.
Remove one useless variable.
All tests should pass.