Fix: Custom link UI does appears outside canvas on the sidebar navigation. #48633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
getdave
reviewed
Mar 3, 2023
| @@ -137,7 +137,6 @@ export function LinkUI( props ) { | |||
| placement="bottom" | |||
| onClose={ props.onClose } | |||
| anchor={ props.anchor } | |||
| __unstableSlotName={ '__unstable-block-tools-after' } | |||
There was a problem hiding this comment.
@jorgefilipecosta This was added in this discussion.
If we change here do we also need to change the other link-ui.js file?
There was a problem hiding this comment.
I updated the PR to also change the other file. I'm not seeing regressions.
There was a problem hiding this comment.
Hopefully this ok then. Thanks 👍
98c85bf to
c0fad8b
Compare
c0fad8b to
b1a10a0
Compare
|
Flaky tests detected in b1a10a098a64534e9744555ca605a2000b557956. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4323456769
|
b1a10a0 to
d62782e
Compare
d62782e to
22046de
Compare
scruffian
approved these changes
Mar 3, 2023
|
It seems that by clicking custom link that one has the option to add a page or post etc. EDIT: As @scruffian Ben touched upon. Having the Appender + sign next to the Navigation title puzzles me. As it feels more intuitive having it below the bottom link. Giving a signal that clicking the + sign adds a new link. Having the + sign next to the Navigation title it could mean almost the same as the 3 dots we can see when hovering the menu links. That the + sign has to do with options for the Navigation and not directly about adding a new nav link. Before
After Using the Gutenberg PR build. Clicking the + appender top right of the Navigation title. It is very helpful to be able to select a specific post/page to add to the Navigation here. Placement needs to be adjusted when there is not enough room below the Navigation for the popup to be seen. |
jorgefilipecosta
added a commit
that referenced
this pull request
Mar 7, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #47930 which was merged last week, we added this unusable flag.
That change seems not to undo the remaining work.
This change makes the custom link popover not appear on the navigation sidebar. This PR reverts the change and makes the popover appear again.
@draganescu as a reviewer of #47930 is this change safe?
Screenshot
Testing
Apply the following diff (because right now we have a bug that causes crashes when there are custom links being addressed by @draganescu and @scruffian):
The diff removes the canvas so we can test a single block list.
Add a custom link and verify the popover appears as shown on the screenshot.