-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Inserter does not appear on sidebar navigation. #48623
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
fix/inserter-does-not-appear-on-sidebar-navigation
Mar 1, 2023
Merged
Fix: Inserter does not appear on sidebar navigation. #48623
jorgefilipecosta
merged 1 commit into
trunk
from
fix/inserter-does-not-appear-on-sidebar-navigation
Mar 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
An existing feature does not function as intended
label
Mar 1, 2023
jorgefilipecosta
deleted the
fix/inserter-does-not-appear-on-sidebar-navigation
branch
March 1, 2023 10:02
Size Change: -1 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Flaky tests detected in dcd7430. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4302255512
|
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 7, 2023
No need to backport this as it was part of: #48689 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ParentId check was recently added by me at #48049.
It was done assuming we would also merge the change to reuse the canvas block editor on the sidebar navigation given that we followed another path this condition needs to be removed.
Testing
Verify the inserter appears on the sidebar navigation.