react-native-editor: move parser tests to a test directory #48615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 1, 2023
|
By the way the Jest config for web unit tests ( https://github.com/WordPress/gutenberg/blob/trunk/test/unit/jest.config.js#L29-L31 If all tests are in correct directories and are not part of build, these patterns should also be redundant. |
|
Nice 👍 I appreciate splitting the atomic changes out of the Jest upgrade PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from the Jest upgrade in #47388 which moves some tests to a
testsubdirectory. The result is that these test files are excluded from the build and are not transpiled and copied into./buildand./build-module.I also removed
../globalsimports from the test files because these imports are already done by the tested modules.Now when the test files are excluded from the build, we no longer need to add the build directories to
testPathIgnorePatterns. These exclusions are difficult to implement once you change therootDirand want to include..in the paths. Paths in regular expressions are not resolved, the expression including..is matched against the real filename, and never matches anything.