Match color of the focus template view with site dark material #48430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Feb 27, 2023
|
Flaky tests detected in 2468feb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4284235848
|
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 598f923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
One minor SCSS change to adapt the background color of the focused template view with the same color as the dark material within the Site Editor. cc @jameskoster
Why?
Matching the colors will help with transitioning into the different focused states within the Site Editor.
How?
Changing the currently used
$gray-800togray-900.Testing Instructions
Screenshots or screencast
Before:
After: