Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect css property in editor-color-palette documentation #48333

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sboerrigter
Copy link
Contributor

.has-strong-magenta-border-color {
	color: #a156b4;
}

should be:

.has-strong-magenta-border-color {
	border-color: #a156b4;
}

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

```
.has-strong-magenta-border-color {
	color: #a156b4;
}
```

should be: 

```
.has-strong-magenta-border-color {
	border-color: #a156b4;
}
```
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 22, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sboerrigter! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@sboerrigter sboerrigter changed the title color css property should be border-color color css property should be border-color in editor-color-palette documentation Feb 22, 2023
@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Feb 23, 2023
@t-hamano t-hamano self-requested a review February 23, 2023 03:28
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sboerrigter
LGTM! Thank you for finding this issue. Moving the background color styles to after the color styles is also a very nice improvement, as it matches the order of the inline styles in the actual output 👍

Before:

before

After:

after

@t-hamano t-hamano changed the title color css property should be border-color in editor-color-palette documentation Fix incorrect css property in editor-color-palette documentation Feb 23, 2023
@t-hamano t-hamano merged commit 68ce88b into WordPress:trunk Feb 23, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @sboerrigter! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@t-hamano t-hamano added this to the Gutenberg 15.3 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants