Lodash: Remove remaining _.get() from core-data
#48310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +321 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Feb 22, 2023
| @@ -66,7 +66,10 @@ function getQueriedItemsUncached( state, query ) { | |||
|
|
|||
| for ( let f = 0; f < fields.length; f++ ) { | |||
| const field = fields[ f ].split( '.' ); | |||
| const value = get( item, field ); | |||
| let value = { ...item }; | |||
There was a problem hiding this comment.
I don't think we need to clone the object here.
There was a problem hiding this comment.
My rationale was that if we directly assign item to value by reference, when we change value on L71, we'll also change item, which may eventually lead to unexpected results if we end up using item somewhere.
Or are you talking about the fact that item is not used after this potential mutation in this branch of the code, so we might as well mutate it?
There was a problem hiding this comment.
my rationale here is that "field" contains at least one element, so there's no way value is going to be item in the end, or am I wrong?
There was a problem hiding this comment.
I think you have a point. Removed in f00713e
youknowriad
reviewed
Feb 22, 2023
packages/core-data/src/selectors.ts
Outdated
| @@ -323,7 +332,10 @@ export const getEntityRecord = createSelector( | |||
| const fields = getNormalizedCommaSeparable( query._fields ) ?? []; | |||
| for ( let f = 0; f < fields.length; f++ ) { | |||
| const field = fields[ f ].split( '.' ); | |||
| const value = get( item, field ); | |||
| let value = { ...item }; | |||
There was a problem hiding this comment.
same cloning doesn't seem needed here?
There was a problem hiding this comment.
See my rationale above. Also, item is used later here so we definitely don't want to inadvertently mutate it.
There was a problem hiding this comment.
even if it's used later, value is never going to be equal to "item" after the loop
|
Flaky tests detected in 4116122. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4242801768
|
youknowriad
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.get()from the@wordpress/core-datapackage. It also adds some missing types whose lack was previously concealed by the Lodash's broad types.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using direct access with optional chaining and nullish coalescing as an alternative. We're also adding some additional types where necessary.
Testing Instructions