Site Editor: Fix the tooltip and shortcut for the global save button #48282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Feb 21, 2023
| @@ -0,0 +1,116 @@ | |||
| /** | |||
There was a problem hiding this comment.
I didn't make any change to these three files, I just split the previous "index.js" file into three components in order to be able to insert them in different contexts. That way we can always make sure that the "save shortcut" works in all modes.
|
Size Change: +7 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 42d4c51. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4232870689
|
ntsekouras
reviewed
Feb 22, 2023
| @@ -12,7 +12,7 @@ import { displayShortcut } from '@wordpress/keycodes'; | |||
| */ | |||
| import { store as editSiteStore } from '../../store'; | |||
|
|
|||
| export default function SaveButton() { | |||
| export default function SaveButton( { showTooltip = true } ) { | |||
There was a problem hiding this comment.
Is there a reason for keeping the tooltip in the header Save button when is disabled?
There was a problem hiding this comment.
yes, there is. In the post editor we want to force the tooltip to show regardless of whether there's a shortcut.
ntsekouras
approved these changes
Feb 22, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 464254d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR does two things:
Testing Instructions
1- Open the site editor
2- The save button should be disabled
3- hovering it shouldn't show any tooltip.
1- Open the site editor
2- Make some changes to anything
3- Make sure you're in browse mode
4- Ctrl+S should bring up the save modal